[Bug 510668] Review Request: canorus - Music Score Editor
bugzilla at redhat.com
bugzilla at redhat.com
Fri Jul 10 19:55:09 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=510668
Jussi Lehtola <jussi.lehtola at iki.fi> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jussi.lehtola at iki.fi
--- Comment #1 from Jussi Lehtola <jussi.lehtola at iki.fi> 2009-07-10 15:55:08 EDT ---
Just a few drive-by comments:
- Shouldn't the menu image go to %{_datadir}/pixmaps? Then you could drop the
hicolor stuff.
- Is the %{_datadir}/%{name}/doc directory accessed by the executable? Is the
documentation in that directory human-readable? If yes, I suggest putting the
doc/ directory in %doc and replacing %{_datadir}/%{name}/doc with a symlink to
%{_docdir}/%{name}-%{version}/doc/, thus simplifying
%doc %{_datadir}/%{name}/doc/
%dir %{_datadir}/%{name}/
%{_datadir}/%{name}/examples/
%{_datadir}/%{name}/fonts/
%{_datadir}/%{name}/images/
%{_datadir}/%{name}/plugins/
%{_datadir}/%{name}/scripts/
to
%doc doc/ (or whatever is the location of the docs in the source tree)
%{_datadir}/%{name}/
- The install command
DESTDIR=%{buildroot} make install DESTDIR=%{buildroot}
has one DESTDIR too much :) You should be able to drop the former one.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list