[Bug 510994] Review Request: gtg - Personal organizer for the GNOME desktop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510994





--- Comment #2 from Yanko Kaneti <yaneti at declera.com>  2009-07-13 03:08:22 EDT ---
(In reply to comment #1)
> 1)Follow https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache

Replaced with the ones from the snippets

> 2) why not to use desktop-file-install?
> See 
> http://fedoraproject.org/wiki/PackagingGuidelines#desktop-file-install_usage

Included the validate snippet.

> 3) you should use 
> %{__python} setup.py install --skip-build --root $RPM_BUILD_ROOT

Ok. 

> 4) You can remove shebang in %prep as
> sed -i -e "s|#!/usr/bin/env python||" GTG/gtg.py  

Ok. Although I think its best to leave upstream sources pristine unless it
results in some package breakage.


SPEC: http://declera.com/~yaneti/gtg/gtg.spec
SRPM: http://declera.com/~yaneti/gtg/gtg-0.1.2-1.fc12.src.rpm

* Mon Jul 13 2009 Yanko Kaneti <yaneti at declera.com> 0.1.2-2
- Implement review feedback
  https://bugzilla.redhat.com/show_bug.cgi?id=510994#c1


Thanks

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.