[Bug 505982] Review Request: zikula-module-MultiHook - MultiHook is a simple replacement for the old AutoLinks module for Zikula

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505982


Ian Weller <ian at ianweller.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(eric at christensenp
                   |                            |lace.us)




--- Comment #6 from Ian Weller <ian at ianweller.org>  2009-07-13 16:10:10 EDT ---
== FULL REVIEW ==

[  OK  ] specfiles match:
  72e5cecad7897770a6b0b4859cdf2308  zikula-module-MultiHook.spec
  72e5cecad7897770a6b0b4859cdf2308  zikula-module-MultiHook.spec.1
[  OK  ] source files match upstream:
  7bcef21d80df346133ce6742b9b7bbb6  MultiHook_5.0.zip
  7bcef21d80df346133ce6742b9b7bbb6  MultiHook_5.0.zip.1
[  OK  ] package meets naming and versioning guidelines.
[ SURE ] spec is properly named, cleanly written, and uses macros consistently.
  I'd add line breaks in between each %changelog entry for legibility, but 
  that's a matter of taste.
[  OK  ] dist tag is present.
[  OK  ] build root is correct.
[FAILED] license field matches the actual license.
  It's actually GPLv2+, check the source files (says "any later version").
[  OK  ] license is open source-compatible.
[  OK  ] license text included in package.
[  OK  ] latest version is being packaged.
[  OK  ] BuildRequires are proper.
[  N/A ] compiler flags are appropriate.
[  OK  ] %clean is present. 
[  OK  ] package builds in mock.
[  OK  ] package installs properly.
[  N/A ] debuginfo package looks complete.
[FAILED] rpmlint is silent. 
  zikula-module-MultiHook.src: W: strange-permission MultiHook_5.0.zip 0770
  Very minor issue, a matter of chmodding your source file in rpmbuild/SOURCES 
  to 644 or 664.
[  OK  ] final provides and requires are sane
[  N/A ] %check is present and all tests pass:
[  N/A ] no shared libraries are added to the regular linker search paths.
[  OK  ] owns the directories it creates. 
[  OK  ] doesn't own any directories it shouldn't.
[  OK  ] no duplicates in %files.
[  OK  ] file permissions are appropriate.
[  N/A ] scriptlets match those on ScriptletSnippets page.
[  OK  ] code, not content.
[  OK  ] documentation is small, so no -docs subpackage is necessary.
[  OK  ] %docs are not necessary for the proper functioning of the package.
[  OK  ] no headers.
[  OK  ] no pkgconfig files.
[  OK  ] no libtool .la droppings.
[  N/A ] desktop files valid and installed properly.

Please fix.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.