[Bug 466183] Review Request: sblim-sfcb - Small Footprint CIM Broker

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466183





--- Comment #13 from Praveen K Paladugu <praveen_paladugu at dell.com>  2009-07-13 23:42:52 EDT ---
Review

## rpmlint sblim-sfcb.spec
sblim-sfcb.spec:16: W: unversioned-explicit-provides cim-server

## rpmlint sblim-sfcb-1.3.4-4.fc11.src.rpm 
sblim-sfcb.src:16: W: unversioned-explicit-provides cim-server
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Since cim-server is not a package, the above warning can be ignored. 



1) There doesn't seem to be a explicit LICENSE file inside the sources. In such
cases it is always better to contact upstream and get them to add the LICENSE
file to the source tar.

2) Every Explicit "Requires:" tag has to be accompanied with a comment with a
justification.
(https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires)

3) Unversioned shared object (ending with *.so) have to moved to devel package.
Thus created devel package should "Requires" the base package with its precise
versioning. Wherever not required, please exclude the static libraries from the
package (remove all *.la files if possible).
(https://fedoraproject.org/wiki/Packaging/Guidelines#Packaging_Static_Libraries)

4) All the init scripts have to be moved to /etc/rc.d/init.d .Use the macro
%{_initddir} to move the init files.
(https://fedoraproject.org/wiki/Packaging:SysVInitScript#Initscripts_on_the_filesystem).

5) The service sfcb seems to be started by default, by turning on the service
using the chkconfig. If a service has to be started by default in any runlevel,
those runlevels must be listed using a $Default-Start tag.
(https://fedoraproject.org/wiki/Packaging:SysVInitScript#.23_Default-Start:_line).

6) All Fedora SysV-style initscripts must contain the # Short-Description: line
in the LSB Header.
(https://fedoraproject.org/wiki/Packaging:SysVInitScript#.23_Short-Description:_line).
All Fedora SysV-style initscripts must contain the # Description: line in the
LSB Header.

7) The init scripts in Fedora must have the functions condrestart and
try-restart defined. The current version only defines the condrestart.
https://fedoraproject.org/wiki/Packaging:SysVInitScript#condrestart_and_try-restart.


Above listed are some of the changes required in this package. I added an url
with every comment for your reference.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.