[Bug 511916] Review Request: dracut-modules-olpc - OLPC initramfs modules

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=511916


Peter Robinson <pbrobinson at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |pbrobinson at gmail.com




--- Comment #2 from Peter Robinson <pbrobinson at gmail.com>  2009-07-15 18:11:31 EDT ---
I'll take this one. Some initial comments.

Source URL isn't correct. It should be:

http://dev.laptop.org/~dsd/dracut-modules-olpc/dracut-modules-olpc-0.2.1.tar.bz2
or
http://dev.laptop.org/~dsd/%{name}/%{name}-%{version}.tar.bz2

Build root isn't the usual one. Something like the following is suggested.

BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

It also doesn't build in koji. I think it needs pyrex.
http://koji.fedoraproject.org/koji/taskinfo?taskID=1477535

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.