[Bug 246525] Review Request: libMini - A high-performance terrain rendering library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=246525





--- Comment #35 from Nicolas Chauvet (kwizart) <kwizart at gmail.com>  2009-07-16 10:49:24 EDT ---
Sorry, I've missed this comment about Mini.pc:
(In reply to comment #29)
...
> BTW: about Libs.private, there was a change lately with pkg-config behaviour. 
> I think most projects were not using Requires.private appropriately...I don't
> remember if libMini could have been affected...  

grep include /usr/include/mini/* -R showed that only curl-devel and
libGLU-devel (along with libGL-devel) should be required by libMini-devel, and
then:
- If only datatype are needed (only cflags but no need to link with -lcurl
-lGLU -lGL), then curl gl glu can be moved to Requires.private.
- If libs are also needed for another package to link with -lMini as a shared
object, then theses curl glu gl needs to be keept in the Requires field.

But it would be fine to request for advices.

Now for ultimate correctness, libMini remaining direct dependencies (-lpng
-ljpeg, etc) need to be mentioned in Libs.private: so they can be searched when
using static linking. (totally optional for this review).

-lglut is probably meant to be moved to Lib.private

In any cases, inaccurate linking dependencies are covered by a "warn upstream"
policy according to our guidelines. so I would like to have a general answea;
no need to upload a new package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.