[Bug 512106] Review Request: rpmconf - Tool to handle rpmnew and rpmsave files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=512106


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #9 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-07-17 05:05:42 EDT ---
(In reply to comment #8)
> > BuildRoot used is archaic. Use
> It was one of recommended in Guideliness. But if you insist on the most
> prefered... Changed.

It was missing at least %{release}.

> > I still don't see why you would want to use "/usr/bin/docbook2man" instead of
> "docbook2man"
> I prefer full paths as it prevent path spoofing. Just my opinion. I'm not
> dogmatic about it. Changed.

But that shouldn't be an issue with the build system.

> > License is GPLv2 not GPLv3. (Source code header is binding.)
> Since I'm upstrem, then what I want is binding :)
> Changed source header to GPLv3. Mention of GPLv2 was mistake.

OK.

**

The package has been

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.