[Bug 511938] Review Request: cld - Coarse locking daemon

bugzilla at redhat.com bugzilla at redhat.com
Fri Jul 17 16:45:06 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=511938





--- Comment #9 from Mike Bonnet <mikeb at redhat.com>  2009-07-17 12:45:04 EDT ---
1) looks good

2) I still see this line in the specfile included in the srpm from comment #8:

find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'

That should be using "find %{buildroot} ..." instead.

3. looks good

4. That's a good addition.  I also meant changing the specfile version/release
to reflect the git commit ID, something like:

Name: cld
Version: 0.1
Release: 0.1.git0df99419

This allows you to increment the release to 0.2.git<first 8 letters of next git
commit ID> for the next release, etc.  When you get to a real release, you can
then just use:

Release: 1

and the nvr-ordering will be preserved.  This is just a recommendation though,
as long as subsequent updates preserve nvr-ordering, I'll leave the details up
to you.

Note that you may also want to put the git commit ID in the filename of
Source0, various tools will complain if the content of a tarball changes but
the filename does not.

5. looks good

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list