[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
bugzilla at redhat.com
bugzilla at redhat.com
Sat Jul 18 13:48:20 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508318
Peter Robinson <pbrobinson at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #16 from Peter Robinson <pbrobinson at gmail.com> 2009-07-18 09:48:17 EDT ---
I think the following is the last bits that needed to be addressed
> Should be using desktop-file-install (the metacity package has
> desktop-file-install usage commented out, with a comment that the .desktop file
> is invalid, but mutter.desktop seems fine)
As there's already a .desktop file for mutter we just need to run
desktop-file-validate on it - FIXED.
> - Although it makes the specfile more complex, I think the check in
> metacity.spec:
>
> SHOULD_HAVE_DEFINED="HAVE_SM HAVE_XINERAMA HAVE_XFREE_XINERAMA HAVE_SHAPE
> HAVE_RANDR HAVE_STARTUP_NOTIFICATION"
>
> for I in $SHOULD_HAVE_DEFINED; do
> if ! grep -q "define $I" config.h; then
> echo "$I was not defined in config.h"
> grep "$I" config.h
> exit 1
> else
> echo "$I was defined as it should have been"
> grep "$I" config.h
> fi
> done
>
> Is probably worthwhile moving over. (And add HAVE_COMPOSITE_EXTENSION)
FIXED.
SPEC: http://pbrobinson.fedorapeople.org/mutter.spec
SRPM: http://pbrobinson.fedorapeople.org/mutter-2.27.1-2.fc11.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1483821
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list