[Bug 472793] Review Request: jgraph - Java graph visualization and layout

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472793





--- Comment #5 from D Haley <mycae at yahoo.com>  2009-07-18 23:55:35 EDT ---
The package looks pretty good. I will do a full review next update:

RPMLint was clean, mock was OK.

Comments:
----

Description is weasel-wordy: 

Most powerful? 
and more? 
First free diagram editor for java -- I think jfig might beat it here (does
jfig have drag'n drop?)
100% pure Java (What does that mean?)
Fully standards-compliant (What standard? ISO 9001? Why do I (user) care?)
etc.

Please make it a bit more descriptive of what the software actually does, and
what the package provides. I can't really tell from the description -- is it
graphing software, can I make x-y plots? Or does it do network graph analysis?
Or just display them?

The README file is a little clearer "A component to display and edit graphs
(networks) with Java" "With the JGraph zoomable component, you can display
objects and relations (networks) in any Swing UI."

Some ideas:
 *Provides automatic 2D layout and routing for diagrams, for swing UIs
 *Allows for generation a wide variety of object-connection relation diagrams
in a java user interface.

----

I am getting errors during the RPM debug information extraction step when
rebuilding (F10). A cursory examination makes me suspect it may be related to
this bug:
https://bugzilla.redhat.com/show_bug.cgi?id=472292

+ /usr/lib/rpm/find-debuginfo.sh --strict-build-id
/home/makerpm/rpmbuild/BUILD/jgraph-5.12.2.1
extracting debug info from
/home/makerpm/rpmbuild/BUILDROOT/jgraph-5.12.2.1-1.fc10.i386/usr/lib/gcj/jgraph/jgraph-5.12.2.1.jar.so
cpio:
jgraph-5.12.2.1/aot-compile-rpm/usr/lib/gcj/jgraph/org/jgraph/JGraph$EmptySelectionModel.java:
Cannot stat: No such file or directory
cpio:
jgraph-5.12.2.1/aot-compile-rpm/usr/lib/gcj/jgraph/org/jgraph/JGraph$GraphSelectionRedirector.java:
Cannot stat: No such file or directory
cpio:
jgraph-5.12.2.1/aot-compile-rpm/usr/lib/gcj/jgraph/org/jgraph/JGraph.java:
Cannot stat: No such file or directory
cpio:
jgraph-5.12.2.1/aot-compile-rpm/usr/lib/gcj/jgraph/org/jgraph/event/GraphLayoutCacheEvent$GraphLayoutCacheChange.java:
Cannot stat: No such file or directory
....

----

Licencing is not clearly LGPLv2+. It might be LGPLv2. LICENSE does not state if
it is "or any later", which is usually indicated in the source files (which do
not show GPL headers, as required by LICENSE). Please raise a bug upstream, and
for now the package will need to be LGPLv2 only.

----

> BuildRequires:  dos2unix

I prefer not using dos2unix for endline conversion. sed is available and
capable of the conversion, and can be used to preserve timestamps. One less
BuildRequires.

$ echo "hi" > helloworld]
$ ls -l helloworld 
-rw-rw-r-- 1 makerpm makerpm 3 2009-07-19 12:30 helloworld
$ unix2dos helloworld 
unix2dos: converting file helloworld to DOS format ...
$ ls -l helloworld 
-rw-rw-r-- 1 makerpm makerpm 4 2009-07-19 12:31 helloworld

Simply use this instead (shamelessly pinched from someone else's review of one
of my packages):

#convert EOL encodings, maintaining timestames
for file in LICENSE examples/com/jgraph/example/SerialGraph.java ; 
do
        sed 's/\r//' $file > $file.new && \
        touch -r $file $file.new && \
        mv $file.new $file
done

----

>%defattr(0644,root,root,0755)

You could simply use (-,root,root,-) here.. Its minor i know.
----

Also, can you please provide koji scratch builds against F-10, F-11?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.