[Bug 510734] Review Request: x11vnc - VNC server for the current X11 session

bugzilla at redhat.com bugzilla at redhat.com
Sun Jul 19 12:20:58 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510734





--- Comment #10 from Christian Krause <chkr at plauener.de>  2009-07-19 08:20:55 EDT ---
(In reply to comment #9)
> No, please don't. Check the discussion in the old bug. The embedded minilzo is
> a feature, not a bug. If you don't want the embedded *minilzo*, then you should
> use lzo, not the forced-shared-minilzo package.
> 
> minilzo is by upstream's definition for embedded, statically linked
> applications.  

Even if I also don't like the large patch to use the external (mini)lzo
library, I still think it is the correct way:

a) there are good reasons (security updates, ...) why the guidelines encourage
not to embed system libraries:
http://fedoraproject.org/wiki/Packaging/Guidelines#Duplication_of_system_libraries

b) the work has already been done

c) libvncserver also uses the system's libminilzo 

c) in other cases ( https://fedorahosted.org/fesco/ticket/134 ) FESCO did not
approve the use of embedded libraries

Given these arguments I'm convinced that using the embedded minilzo is not
acceptable (the same applied for the embedded libvncserver).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list