[Bug 501573] Review Request: ndoutils - Stores data from Nagios in a database

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=501573





--- Comment #14 from Steve Traylen <steve.traylen at cern.ch>  2009-07-20 17:28:54 EDT ---
Thanks for all the comments, hopefully all addressed:

http://cern.ch/steve.traylen/ndoutils-rpm/ndoutils-1.4-0.4.b7.fc11.src.rpm
http://cern.ch/steve.traylen/ndoutils-rpm/ndoutils.spec

from the .spec file:
- Patch ndomod.o to be ndomod.so since it was a shared object.
- Move ndomod.so from /usr/lib to /usr/lib/nagios/brokers
- Change URL to better one.
- Change SourceURL to fedora package guideline for sourceforge.
- Completely removed postgres support. The documents clearly state
  it is not supported.

In particular postgres is mentioned as not being supported in the docs and 
moreover in the new b8 release it is even removed from the configure
options. Consequently I have removed all traces of postgres support. It
can be added later.

In fact the .a file in /usr/lib was a .so file but hardcoded to be a .a. 
This is now patched to be a .so. Concerning your question about where it 
should go this ndomod.so is the same to nagios as say mod_alias.so is to
httpd. So I put in  /usr/lib/nagios/brokers which makes a lot more sense.

A good koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1487645

rpmlint ndoutils-1.4-0.4.b7.fc11.src.rpm \
        ndoutils-1.4-0.4.b7.fc11.x86_64.rpm \
        ndoutils-mysql-1.4-0.4.b7.fc11.x86_64.rpm

ndoutils.x86_64: W: non-standard-uid /var/cache/ndoutils nagios
ndoutils.x86_64: W: non-standard-uid /var/run/ndoutils nagios
ndoutils.x86_64: W: non-standard-uid /var/log/ndoutils nagios
ndoutils.x86_64: W: log-files-without-logrotate /var/log/ndoutils
ndoutils.x86_64: W: incoherent-init-script-name ndo2db ('ndoutils',
'ndoutilsd')

which are all explained above.

 Steve.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.