[Bug 511276] Review Request: comoonics-base-py - Comoonics minimum baselibraries written in Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=511276





--- Comment #9 from Nils Philippsen <nphilipp at redhat.com>  2009-07-21 08:36:04 EDT ---
I still found some issues:

- BAD: rpmlint still warns about the non-coherent filename:

   nils at gibraltar:~/devel/fedora-review/comoonics-base-py> rpmlint comoonics-
   base-py-0-1-2-src.rpm 
   comoonics-base-py.src: W: non-coherent-filename comoonics-base-py-0-1-2-
   src.rpm comoonics-base-py-0.1-2.src.rpm
   1 packages and 0 specfiles checked; 0 errors, 1 warnings.

   --> the file name should contain the version as "0.1", not "0-1" -- do you
have any fancy RPM macros which change the resulting file names when building
packages?

- BAD: the spec file still contains the vendor tag, cf.
https://fedoraproject.org/wiki/Packaging/Guidelines#Tags: "The Vendor tag
should not be used. It is set automatically by the build system."

- CHECK: you still %define name, version, release, then later use "Name:
%{name}" etc. This is unnecessary and potentially confusing, just use "Name:
comoonics", "Version: 0.1", "Release: 2" and the macros should be set
accordingly.

- CHECK/BAD: no source tarball URL, it would be good if the tarball used were
directly available -- see https://fedoraproject.org/wiki/Packaging/SourceURL.
Needless to say, if the tarball contents change (e.g. license, readme added),
the version has to be bumped (e.g. to 0.1.1 in this case).

- BAD: not all shipped directories owned by package, direct dependency or
filesystem

--> Requires: python

These slipped past me in the first review:

- BAD: The BuildRoot value MUST be below %{_tmppath}/ and MUST contain at least
%{name}, %{version} and %{release}. It may invoke mktemp since this is
guaranteed to exist on every system. From there, packagers are expected to use
a sane BuildRoot. See
https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag for details
and recommended values.

- CHECK: You use "%setup -q -n %{name}-%{version}" in the spec file, plainly
using "%setup -q" is sufficient.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.