[Bug 513497] Review Request: ovirt-viewer - A vnc viewer for oVirt managed vms

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513497


Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net




--- Comment #1 from Fabian Affolter <fabian at bernewireless.net>  2009-07-24 11:19:56 EDT ---
Just some comments after a quick look at your spec file:

- You are mixing '%{buildroot}' and '$RPM_BUILD_ROOT'
 
https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS
  Please take a look at
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

- The man pages are automatically compressed by RPM

- README and COPYING must be added to the %files section.
  https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25files_prefixes

- Isn't %configure instead of ./configure working?
  https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25build_section

- Aren't gtk2, gtk-vnc, and gnutls automatically picked up by RPM?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.