[Bug 511212] Review Request: cluster-glue - reusable clustering components

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=511212





--- Comment #16 from Andrew Beekhof <andrew at beekhof.net>  2009-07-28 01:35:03 EDT ---
(In reply to comment #15)
> a9aba6ae59030a148dd95bfea163852c  75cab275433e.tar.gz
> ecc791dec7788293ad3d7f22b1d80cf5  75cab275433e.tar.gz.orig

> Issues: 
> 
> 1. What is the 'uid' define for? 

Copied from heartbeat.spec, will remove.

> 2. You should use %global instead of %define. 

can do

> 3. Is this a pre-release for version 1.0? Or a post release of 0.9? or
> something else?

pre-release of 1.0

I'll change the version and add the hg revision as part of the alphatag.

> The release might need adjustment. See: 
> https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Release
> I suspect it should be something like: 1.0.0-0.0.75cab275433e ?
> 
> 4. The %{configure} macro should pass all of these I think, so no need to do
> so: 
>                 --prefix=%{_prefix} \
>                 --localstatedir=%{_var} \
>                 --libdir=%{_libdir}

Will remove and confirm.

> 5. Your source doesn't match the upstream Source url. Perhaps you are using a
> checkout? 
> It needs to match exactly. 

Mercurial embeds the repo in the tarball (in the .hg_archival.txt file).

[beekhof at rawhide Pacemaker-1-0-c9120a53a6ae]$ cat .hg_archival.txt 
repo: 8448b17e67437947c48c639c6faa4371c4a14b3b
node: c9120a53a6ae63119f96456cafb082d3c9f8a3d2

I forgot about this and only confirmed that the new url worked, not that
md5sum's matched.
Consistent use of hg.linux-ha.org for all tarballs will avoid this problem.


New SRPM/SPEC to follow

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.