[Bug 513541] Review Request: cpulimit - CPU Usage Limiter for Linux

bugzilla at redhat.com bugzilla at redhat.com
Wed Jul 29 09:16:18 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513541


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussi.lehtola at iki.fi




--- Comment #16 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-07-29 05:16:17 EDT ---
Don't bother with autotools. There's nothing wrong with a package that builds
without them, especially when the build process is this simple.

In fact, you don't even need to use the makefile (since it doesn't support
optflags). I recommend that you drop Patch0 and

 %setup -q

 %build
 gcc $RPM_OPT_FLAGS -lrt -o cpulimit cpulimit.c

 %install
 rm -rf $RPM_BUILD_ROOT
 install -p -m 755 cpulimit $RPM_BUILD_ROOT/%{_bindir}/cpulimit

**

Besides, your Patch is *creating* the files
AUTHORS COPYING README INSTALL ChangeLog

If you want to ship these, list them as extra Source lines. Where did you get
these, anyway..? The tarball only contains the source code file and the simple
Makefile.

**

I am willing to sponsor you, if you show me you know the Fedora guidelines; the
most important of which are
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets

To do this you need to make another submission, and perform two informal
reviews of packages of other people. Please review only packages not marked
with the FE-NEEDSPONSOR blocker as I will have to do the full formal review
after you to check that you have got everything right.

After being sponsored, you are able to do reviews of your own.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list