[Bug 513774] Review Request: python-firkin - A python module to convert between different measurement units
bugzilla at redhat.com
bugzilla at redhat.com
Wed Jul 29 22:57:16 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513774
Jason Tibbitts <tibbs at math.uh.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu> 2009-07-29 18:57:15 EDT ---
Not much to this one; builds fine and rpmlint is clean.
* source files match upstream. sha256sum:
f53e67eac5d04b7cfb52803ff9eb907bfacb115bbdfdef882c7a5907d6d0ae4e
firkin-0.02.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
python-firkin = 0.02-1.fc12
=
python(abi) = 2.6
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
APPROVED
The package review process needs reviewers! If you haven't done any package
reviews recently, please consider doing one.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list