[Bug 514602] Review Request: system-config-audit - an utility for editing audit configuration

bugzilla at redhat.com bugzilla at redhat.com
Thu Jul 30 17:22:47 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=514602





--- Comment #3 from Miloslav Trma─Ź <mitr at redhat.com>  2009-07-30 13:22:46 EDT ---
Thanks for the review.

(In reply to comment #2)
> Just 3 issues I labeled with a letter in case discussion is needed. Looking
> over the spec file:
> A) release should be 1%{?dist}
Dist tag usage is not mandatory:
https://fedoraproject.org/wiki/Packaging:DistTag#Do_I_Have_To_Use_the_Dist_Tag.3F

> I get the following errors from rpmlint:
> 
> B) system-config-audit.src: E: no-cleaning-of-buildroot %install
> C) system-config-audit.src: E: no-buildroot-tag  
These are done automatically by recent RPM versions:

https://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag
https://fedoraproject.org/wiki/PackagingGuidelines#Prepping_BuildRoot_For_.25install

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list