[Bug 468329] Review Request: sblim-indication_helper - Toolkit for CMPI Indication Providers

bugzilla at redhat.com bugzilla at redhat.com
Fri Jul 31 10:41:48 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468329





--- Comment #6 from srinivas <srinivas_ramanatha at dell.com>  2009-07-31 06:41:46 EDT ---
Review:

Fix all rpmlint errors/warnings:

[root at srini-f11 rpmbuild]# rpmlint SPECS/sblim-indication_helper.spec 
SPECS/sblim-indication_helper.spec: W: mixed-use-of-spaces-and-tabs (spaces:
line 1, tab: line 11)
0 packages and 1 specfiles checked; 0 errors, 1 warnings.
[root at srini-f11 rpmbuild]# rpmlint
SRPMS/sblim-indication_helper-0.4.2-1.fc11.src.rpm 
sblim-indication_helper.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1,
tab: line 11)
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[root at srini-f11 rpmbuild]# rpmlint RPMS/x86_64/sblim-indication_helper-*
sblim-indication_helper.x86_64: E: devel-dependency glibc-devel
sblim-indication_helper-devel.x86_64: W: no-dependency-on
sblim-indication_helper/sblim-indication_helper-libs/libsblim-indication_helper
3 packages and 0 specfiles checked; 1 errors, 1 warnings.

naming: ok ( I would prefer it to have a "-" between the words)
spec file name matches: ok 
license = CPL : ok
license tag: ok
spec in english: ok
spec legible: ok
no prebuild binaries: ok
no packager, vendor, copyright, tags: ok
summary and description tags: ok
no rpaths: ok
no config files: ok
no initscripts: ok
no desktop files: ok
consistent use of macros: ok
no makeinstall: ok
no lang files: ok
scriptlets: ok
no conditional deps: ok
builds with a normal user account: ok
not relocatable: ok
code, not content: ok
directory ownership: ok
users and groups: ok
not a web app: ok
conflicts: ok
no kmods: ok
no files under /srv: ok
source matches: ok
calls ldconfig appropriately: ok
no duplicate files: ok
file permissions: ok
libtool archives removed: ok
%clean section: ok
no large docs, no need for -doc subpackage: ok
%doc usage ok
no static libs: ok
no pkgconfig files: ok
all libtool .la files removed: ok
dir ownership correct: ok
%install does rm: ok
filenames UTF8: ok

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list