[Bug 503278] Review Request: nekobee-dssi - Acid sounds synthesizer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503278


Mattias Ellert <mattias.ellert at fysast.uu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mattias.ellert at fysast.uu.se
               Flag|                            |fedora-review?




--- Comment #1 from Mattias Ellert <mattias.ellert at fysast.uu.se>  2009-06-04 10:13:22 EDT ---
Fedora review nekobee-dssi-0.1.7-1.fc10.src.rpm 2009-06-04

$ rpmlint *.rpm nekobee-dssi.spec 
nekobee-dssi.x86_64: W: dangling-relative-symlink /usr/bin/nekobee
jack-dssi-host
3 packages and 1 specfiles checked; 0 errors, 1 warnings.

* OK
! needs attention

* rpmlint is OK - the dangling symlink is satisfied with a dependency

* the package is named according to the guidelines

* the specfile is is named after the package

* the package is licensed under a Fedora approved license (GPLv2+)

* the license tag matches the licens statements in the sources

  One file (src/nekobee_synth.h) says that part of the file is
  LGPLv2.1, but "LGPLv2.1 gives you permission to relicense the code
  under any version of the GPL since GPLv2"

  https://fedoraproject.org/wiki/Licensing#Footnote7

  so this relicensing is permitted.

* the license file (COPYING) is included as %doc

* the spec file is written in legible English

* source matches upstream

e8b491b83e77f778df542d0066271d40  nekobee-0.1.7.tar.gz
e8b491b83e77f778df542d0066271d40  SRPM/nekobee-0.1.7.tar.gz

* package builds in mock (Fedora 10)

* build requires are sane

* package owns its directories or depend on packages that do

* no duplicate files

* permissions are sane and %files has %defattr

* %clean clears buildroot

* desktop files are installed using desktop-file-install

* package does not own other's directories

* %install clear buildroot

* installed filenames are UTF8

! the package installs an icon file but does not have any icon cache
  handling scriptlets. See

https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.