[Bug 505155] Review Request: libcap-ng - An alternative posix capabilities library
bugzilla at redhat.com
bugzilla at redhat.com
Thu Jun 11 10:39:12 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=505155
Jussi Lehtola <jussi.lehtola at iki.fi> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jussi.lehtola at iki.fi
--- Comment #2 from Jussi Lehtola <jussi.lehtola at iki.fi> 2009-06-11 06:39:10 EDT ---
A couple of notes:
- Doesn't
%configure --disable-static
disable building the static library?
- Normally, you don't need to
mkdir -p $RPM_BUILD_ROOT/%{_mandir}/{man3,man8}
mkdir -p $RPM_BUILD_ROOT/%{_lib}
as make install will do this for you. Also, you need to
rm -rf $RPM_BUILD_ROOT
at the beginning of %install.
- You shouldn't need to define attributes in %files. If the attributes are not
correct, the Makefile should be adjusted to give 644 for normal files and 755
for libraries and binaries (or set the attributes using chmod in %install).
- Time stamps are not preserved, use
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list