[Bug 487052] Review Request: dc3dd - Patched version of GNU dd for use in computer forensics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487052


Orcan 'oget' Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |oget.fedora at gmail.com
         AssignedTo|nobody at fedoraproject.org    |oget.fedora at gmail.com
               Flag|                            |fedora-review?




--- Comment #1 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-03-01 02:23:09 EDT ---
I had a look at this package. Here are my notes:

! Not a blocker but a suggestion: The recommended buildroot values are given in
   http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

* Source0 is wrong.

* rpmlint says:
   dc3dd.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/dc3dd-6.12.2/README
You can probably correct this with
   sed 's|\r||' README > README.tmp
   touch -r README README.tmp
   mv -f README.tmp README
in %prep.

* Please remove the binary .gmo files in %prep.

* It looks like the files NEWS, Options_Reference.txt, Sample_Commands.txt
should go to %doc.

* Each package must consistently use macros. Please make use of the %{name}
macro.

* Parallel make must be supported whenever possible. If it is not supported,
this should be noted in the SPEC file as a comment.

* The file lib/getdate.c is GPLv2+. That makes the license GPLv2+ and GPLv3+.

? What is the directory build-aux and the executable files in the root of the
source tree for?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.