[Bug 226423] Merge Review: smartmontools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226423





--- Comment #2 from Michal Nowak <mnowak at redhat.com>  2009-03-02 06:13:46 EDT ---
> License:        GPLv2+

Missing license in: cciss.cpp cciss.h

> BuildRoot:      %{_tmppath}/%{name}-%{version}-root

https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

> PreReq:         /sbin/chkconfig /sbin/service

1) https://fedoraproject.org/wiki/Packaging:Guidelines#PreReq
2) Better use the ``pkgname'' instead of ``/some/path/app''

> BuildRequires: readline-devel ncurses-devel /usr/bin/aclocal /usr/bin/automake /usr/bin/autoconf util-linux groff gettext

Better use the ``pkgname'' instead of ``/some/path/app''

> Obsoletes:      kernel-utils smartmontools-config

Still necessary?

> ExclusiveArch:  i386 x86_64 %{arm} ia64 ppc ppc64

F-11 is going to be i586, %{ix86} is your friend.

> %preun
> if [ "$1" = "0" ] ; then
>  /sbin/service smartd stop >/dev/null 2>&1
>  /sbin/chkconfig --del smartd
> fi
> exit 0
`-^^^^^^

I guess it's not necessary in recent Fedora.

https://fedoraproject.org/wiki/Packaging:Guidelines#Scriptlets

> %triggerpostun -- kernel-utils
> /sbin/chkconfig --add smartd
> exit 0

``kernel-utils'' does not seeems to be present in Fedora anymore. Dump it?

> %defattr(-,root,root)

Use %defattr(-,root,root,-)

> %{_sysconfdir}/rc.d/init.d/smartd

Use:   %{_initrddir}         

# %ghost %verify(not md5 size mtime) %config(noreplace)
%{_sysconfdir}/smartd.conf

> Dump it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.