[Bug 487665] Review Request: soud - Tools for hardware related services based on udev events

bugzilla at redhat.com bugzilla at redhat.com
Mon Mar 2 14:20:44 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487665





--- Comment #8 from Marcela Maslanova <mmaslano at redhat.com>  2009-03-02 09:20:42 EDT ---
(In reply to comment #6)
> OK, so looking this over, this doesn't seem right.
> 
> 1) It implements a critical path in the boot process... in perl.

As a maintainer of perl I'm really interested in this one. Could you be more
precise about it?

> 2) It's needlessly baroque for what it does. You set up a perl daemon to listen
> to udev for events, look for events of a certain type, and then run actions.
> 
> Why not just write udev rules that run actions on certain events, and cut out
> the daemon middleman?
> 
> 3) It's set to start bluetooth only if it's configured to start. Which means
> it's likely to have *already started*, and therefore doesn't decrease the
> running daemon footprint at all.
> 
> 4) It drops stuff into predictable file names in /tmp, which is a security
> hole. (Presumably, that's leftover debugging)
> 
> CC'ing some other people who may have ideas on how to better implement this.

I suppose all your comments were answered. Could we push it to cvs now?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list