[Bug 478852] Review Request: lpairs - Classical memory game with cards

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478852





--- Comment #2 from Michael Schwendt <bugs.michael at gmx.net>  2009-03-03 06:16:12 EDT ---
> Requires:	SDL >= 1.0

Ancient. Really should be removed in favour of the automatic libsdl soname
dependency.


> %configure
[...]
> %makeinstall inst_dir="%{buildroot}%{_datadir}/%{name}"

Rather:

%configure inst_dir="%{_datadir}/%{name}"
[...]
make DESTDIR=%{buildroot} inst_dir="%{_datadir}/%{name}" install


> %defattr(0644,root,root,0755)

%defattr(-,root,root,-) won't work? Why?


* desktop-file-install warns about the Icon= entry

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.