[Bug 488198] Review Request: sugar-update-control - Activity update control panel for Sugar

bugzilla at redhat.com bugzilla at redhat.com
Tue Mar 3 18:36:42 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488198


Suravee Suthikulpanit <suravee.suthikulpanit at amd.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |suravee.suthikulpanit at amd.c
                   |                            |om




--- Comment #1 from Suravee Suthikulpanit <suravee.suthikulpanit at amd.com>  2009-03-03 13:36:40 EDT ---
This is an unofficial review:

Please check the following: 

---------------
- rpmlint -iv sugar-update-control.spec 
sugar-update-control.spec:42: E: files-attr-not-set
A file or a directory entry in a %files section does not have attributes set
which may result in security issues in the resulting binary package depending
on the system where the package is built.  Add default attributes using
%defattr before it in the %files section, or use per line %attr's.

sugar-update-control.spec:44: E: files-attr-not-set
A file or a directory entry in a %files section does not have attributes set
which may result in security issues in the resulting binary package depending
on the system where the package is built.  Add default attributes using
%defattr before it in the %files section, or use per line %attr's.

sugar-update-control.spec:45: E: files-attr-not-set
A file or a directory entry in a %files section does not have attributes set
which may result in security issues in the resulting binary package depending
on the system where the package is built.  Add default attributes using
%defattr before it in the %files section, or use per line %attr's.

0 packages and 1 specfiles checked; 3 errors, 0 warnings.

---------------
- rpmlint -iv
~/rpmbuild/RPMS/noarch/sugar-update-control-0.20-1.fc10.noarch.rpm 
sugar-update-control.noarch: I: checking
sugar-update-control.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/bitfrost/util/urlrange.py 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

sugar-update-control.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/bitfrost/update/microformat.py 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

sugar-update-control.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/bitfrost/update/actutils.py 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

sugar-update-control.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/bitfrost/update/actinfo.py 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

sugar-update-control.noarch: E: incorrect-locale-subdir
/usr/share/locale/pseudo/LC_MESSAGES/sugar-update-control.mo
1 packages and 0 specfiles checked; 5 errors, 0 warnings.
---------------

Please see http://fedoraproject.org/wiki/PackagingGuidelines#File_Permissions.
Also, rerun "rpmlint -iv" on the "src.rpm" and "rpm" before submission. The
above errors seems to be fixed by adding "%defattr(-,root,root,-)" in the file
section. However, "rpmlint -iv" gives many other warnings.

- It seems like the "/usr/share/sugar" directory is own by other package.
Please see
http://fedoraproject.org/wiki/PackagingGuidelines#File_and_Directory_Ownership


SUGGESTIONS:
- Use %{_datadir} instead of "/usr/share"
- Please provide instruction on how to get the latest upstream package (tar.gz)
for checksum comparison.
- Use "rm -rf" instead of "rm"

OKAYS:
- Lincensing (GPLv2+), license file included in the package.
- Buildroot is correct

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list