[Bug 487114] Review Request: gvrpcd - A program for announcing VLANs using GVRP.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487114





--- Comment #5 from Jasper Capel <capel at stone-it.com>  2009-03-03 13:58:39 EDT ---
I created a new init-script from scratch, this one should be compliant.

I'll advise upstream about the license, and the broken link in the README (I
think this should be http://wiki.wireshark.org/GVRP).

I added some comments to the sysconfig-file, and commented the option-lines, so
they should now only be set if a user wants to override defaults set in the
init script.

rpmlint does still complain:
gvrpcd.x86_64: W: service-default-enabled /etc/rc.d/init.d/gvrpcd

It made sense to me to enable gvrpcd by default when installed - it is not a
network daemon listening on any sockets, so it shouldn't be a security risk. On
the other hand, if it's not started the server might not even be able to
communicate. If you don't share this view, I'll disable it as it's not a big
deal to enable the daemon by hand either. :)

gvrpcd.x86_64: W: incoherent-subsys /etc/rc.d/init.d/gvrpcd $prog

I think this is because of the $prog, instead of gvrpcd in the init-script and
can be ignored.

New files:
SRPM: http://bender.newnewyork.nl/review/gvrpcd-1.1-3.fc11.src.rpm
SPEC: http://bender.newnewyork.nl/review/gvrpcd.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.