[Bug 469686] Review Request: ogre-meshmagick - Command line manipulation tool for Ogre meshes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469686





--- Comment #3 from Dan Horák <dan at danny.cz>  2009-03-04 04:24:15 EDT ---
formal review is here, see the notes below:

OK source files match upstream (no difference between the included archive and
fresh svn checkout):
     730a995b66ca2486fe833cb77d963bd613e3db77 
/home/dan/projects/fedora/reviews/meshmagick-0.5.2.tar.bz2
OK package meets naming and versioning guidelines.
BAD specfile is properly named, is cleanly written and uses macros
consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible (LGPLv2+). License text included in
package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
BAD debuginfo package looks complete.
OK rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK shared libraries are added to the regular linker search paths, scriptlets
exists
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK headers in -devel
OK pkgconfig files in -devel
OK no libtool .la droppings.
OK not a GUI app.


- move the shared library into -libs subpackage otherwise the package will not
work in multilib environment
- there is no debuginfo for /usr/bin/meshmagick
    you need to filter-out the "-s" option given to gcc, see configure.in line
20

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.