[Bug 488105] Review Request: rubygem-htmlentities - A module for encoding and decoding (X)HTML entities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488105


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?




--- Comment #2 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-03-04 05:07:31 EDT ---
Thank you for a quick review!
(In reply to comment #1)

> ? The other rubygem packages have BR: ruby(rubygems). This one has BR:
> rubygems. Why is there a difference? Does it matter? 
- No deference, however I prefer to use ruby(rubygems) so I will
  switch to ruby(rubugems)

> Also BR: ruby(abi) =
> %{rubyabi} will be pulled up by BR: rubygems. Do we really need to specify it
> specifically? I know the guidelines tell us to do so.
- I usually add this abi dependency for BR explicitly to make it
  consistent with Requires of ruby abi dependency.

> ! The ruby guidelines tell us to use %global instead of %define. While it
> doesn't matter much in this case, it would be good to obey the guidelines.
- Will change.

-----------------------------------------------------
New Package CVS Request
=======================
Package Name:          rubygem-htmlentities
Short Description:     A module for encoding and decoding (X)HTML entities
Owners:                mtasaka
Branches:              F-10 F-9 
InitialCC:             (nobody)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.