[Bug 486757] Review Request: divine-mc - Multi-core model checking system for proving specifications

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486757





--- Comment #6 from Milos Jakubicek <xjakub at fi.muni.cz>  2009-03-04 18:50:23 EDT ---
OK, there are some more outstanding problems:

- patches: Please put the patch3 (gcc4.4) and patch4(flex) also into upstreams
bugtracker system and paste the link into spec file. The patches are well
commented, however, the comments are usually put directly to the "PatchX:"
section in the beginning of the spec file. It would be nice if you follow this
habit as described on:
https://fedoraproject.org/wiki/PackagingDrafts/PatchUpstreamStatus

- gcc flags: because you can't use the %configure macro, you have to add
'export CXXFLAGS="%{optflags}" CFLAGS="%{optflags}"' before calling configure
to ensure that the flags are propagated. You don't need to call it in "make
CXXFLAGS..." then.
Moreover you should remove -fomit-frame-pointer (this is prohibited in Fedora,
it makes debugging harder or impossible) and -pipe+ (gcc doesn't seem to know
it -- don't know what's the difference to -pipe which is in Fedoras standard
gcc flags).

- please remove the "true --libdir=%{_libdir}", this is not a rpmlint bug,
rpmlint is not intended to have always right: it just prints a warning then,
which is completely ok as the packages does what rpmlint says. Its just fine in
this case, no reason to make rpmlint foolish.

- too see what's going on in the build (e.g. to see the gcc flags), please add
VERBOSE=1 to make. You can also directly call make -k instead of make MAKE=make
-k, don't you (not tried)?:
make -k %{?_smp_mflags} VERBOSE=1

- the examples/ should be simply packaged as %doc too.

- please redirect the output of ./_build/tools/divine-mc help into /dev/null

- there are some prebuilt jars, which must be rebuilt from source or removed.
The sources for them are located at
http://svn.foldr.org/~michaelw/nips-promela-compiler/trunk/ (according to
upstream information), as I doubt they will be useful for any other package in
Fedora, I'd suggest adding them as Source1.. Please refer to the Java
Guidelines when building them:
https://fedoraproject.org/wiki/Packaging/Java

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.