[Bug 483451] Review Request: k3guitune - Musical instrument tuner

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483451


Orcan 'oget' Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |oget.fedora at gmail.com
         AssignedTo|nobody at fedoraproject.org    |oget.fedora at gmail.com
               Flag|                            |fedora-review?




--- Comment #1 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-03-05 02:34:10 EDT ---
1. First, replace those links with relative ones. This is all you need to do.
To get a better understanding, look at the symlink
  /usr/share/doc/HTML/en/k3guitune/common --> ../common
Here, the symlink points to /usr/share/doc/HTML/en/common, which looks like
dangling, but it isn't because /usr/share/doc/HTML/en/common belongs to the
kdelibs-common which is in the dependency chain (it will be pulled up by
kdelibs3). 

For the other language files, the symlinks will remain dangling until the user
installs the relevant language package, for instance: kde-i18n-German
We don't require language packages explicitly, so we will have to ignore these
rpmlints.

2- You need to add BR: alsa-lib-devel. Otherwise alsa support won't be
compiled.
To fix the segfault use this patch:
   http://www.info-telecom.com/files/k3guitune-1.01-fftw.patch
which I found in 
   http://www.kde-apps.org/content/show.php/K3Guitune?content=15358

3- Can you fix the k3guitune-desktop-file.patch accordingly then?

Other than these, can you explain (as comments in the SPEC file) what the
patches do and give links from the upstream tracking system?

Also, where does the xpm file come from? Any possible license issues? If not,
this one also deserves some explanation in the SPEC file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.