[Bug 488185] Review Request: php-pecl-selinux - SELinux binding for PHP scripts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488185





--- Comment #8 from KaiGai Kohei <kaigai at kaigai.gr.jp>  2009-03-05 20:54:54 EDT ---
> The "re2c" is a parser engine, so this package has no relations.
> Now I asks for PHP experts to confirm whether my understanding is correct,
> or not.
>   http://marc.info/?l=pecl-dev&m=123621647005625&w=2

PHP expert also agreed to ignore this warning in this package.
  http://marc.info/?l=pecl-dev&m=123627059603922&w=2

(In reply to comment #7)
> Okay, two issues/questions
> 
> * Source tarball
>   - source tarball in your srpm differs from what I could download
>     from the URL written in your spec file.
>     Does this mean that the source tarball used is the pre-release
>     of 0.1.2? If so, please follow "Pre-release package" naming guideline.

Sorry, it was the regenerated tarball from CVS repos in same version by my
hand.
The correct tarball is the one uploaded at:
  http://pecl.php.net/selinux

It was fixed on updated SRPM.

> * %changelog
>   - EVR (Epoch-Version-Release) information in %changelog differs
>     from the actual EVR of this rpm. Please fix it.  

Oops, "x.y.z" was "x.z.y".
Fixed.

The updated packages are here:
Spec: http://sepgsql.googlecode.com/files/php-pecl-selinux.spec.20090306
SRPM: http://sepgsql.googlecode.com/files/php-pecl-selinux-0.1.2-1.fc10.src.rpm

Thanks,

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.