[Bug 488913] Review Request: perl-IPC-System-Simple - Run commands simply, with detailed diagnostics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488913


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-03-06 01:48:45 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1225733
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
deb1df36a184a6a5af0716f1acb8c70f  IPC-System-Simple-1.18.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=20, Tests=130,  3 wallclock secs ( 0.10 usr  0.01 sys +  1.91 cusr  0.23
csys =  2.25 CPU)
+ Package perl-IPC-System-Simple-1.18-1.fc11-noarch =>
  Provides: perl(IPC::System::Simple) = 1.18
  Requires: perl >= 0:5.006 perl(Carp) perl(Config) perl(Exporter)
perl(List::Util) perl(POSIX) perl(Scalar::Util) perl(constant) perl(re)
perl(strict) perl(warnings)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.