[Bug 454018] Review Request: tcl-tkpng - Tcl/Tk support for PNG

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454018


Deji Akingunola <dakingun at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




--- Comment #3 from Deji Akingunola <dakingun at gmail.com>  2009-03-06 22:48:34 EDT ---
== REVIEW ==

- package follows naming guidelines
- package follows general packaging guidelines
- package follows the tcl packaging guidlines
- licensing: TCL
- source matches upstream
  43347d3d805a5bf3ff428ed812834230  rpmbuild/SOURCES/tkpng0.9.tgz
- package compiles on F10 x86_64
- package contains no locales
- spec file uses macros consistently
- rpmlint run on packages' src.rpm and binary rpm without warnings or errors

OBSERVATION:
Package build log shows 'checking if 64bit support is requested... no' during
the configure stage. While I'm not sure what the implication of that is (or
might be) for the package, the 64bit support can be turned on by passing
'--enable-64bit' option to the configure script.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.