[Bug 483696] Review Request: libdmapsharing - library for DAAP and DPAP

bugzilla at redhat.com bugzilla at redhat.com
Sat Mar 7 14:47:18 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483696


Michael Schwendt <bugs.michael at gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #4 from Michael Schwendt <bugs.michael at gmx.net>  2009-03-07 09:47:18 EDT ---
Okay. libdmapsharing-1.9.0.3-1.fc10.src.rpm gets my APPROVAL.

[...]

Except (!) for one problem introduced in the .pc file, which you want to fix
upstream and in pkg cvs. Here's the diff:

-Libs: -L${libdir} -ldmapsharing- at LIBDMAPSHARING_MAJORMINOR@
-Cflags: -I${includedir}/libdmapsharing- at LIBDMAPSHARING_MAJORMINOR@
+Libs: -L${libdir} -ldmapsharing
+Cflags: -I${includedir}/libdmapsharing

The Cflags point to a non-existant directory now. The headers are found in
/usr/include/libdmapsharing-1.9/libdmapsharing/ instead. As you want API users
to include <libdmapsharing/foo.h> instead of <foo.h>, the previous Cflags line
was correct.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list