[Bug 483381] Review Request: metromap - Simple program for finding paths in subway/metro maps

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483381


Alexey Torkhov <atorkhov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #5 from Alexey Torkhov <atorkhov at gmail.com>  2009-03-07 12:40:22 EDT ---
+ rpmlint output clean:

2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
  %{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The License field in the package spec file matches the actual license.
+ File, containing the text of the licenses for the package is included in
  %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package must matches the upstream source, as
  provided in the spec URL.

f3a92b70f7a282ad7b0ff52bec645ab2  metromap-0.1.2.tar.bz2
f3a92b70f7a282ad7b0ff52bec645ab2  metromap-0.1.2.tar.bz2.orig

+ The package successfully compiles and builds into binary rpms on at least
  one supported architecture (x86_64).
+ All build dependencies are listed in BuildRequires.
+ The spec file handles locales properly.
+ Does not contain shared libraries.
+ The package does not designed to be relocatable.
+ A package owns all directories that it creates.
+ A package does not contain any duplicate files in the %files listing.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot}.
+ The package consistently uses macros.
+ The package contains code, or permissable content.
+ Does not contain large documentation files.
+ Includes only doc files in %doc.
+ No headers.
+ No static libraries.
+ The package does not contain pkgconfig(.pc) files.
+ The package does not contain library files with a suffix (e.g.
  libfoo.so.1.1).
+ No devel packages.
+ The package does not contain any .la libtool archives.
+ Includes %{name}.desktop file. Properly installed with desktop-file-install.
+ The package does not own files or directories already owned by other
  packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot}.
+ All filenames in the package are valid UTF-8.

SHOULD:
Source package does not include license text for data. Query upstream
to include it.

Source package does not specify what GPL version it is under. Query upstream
what intended version is and to correct the sources.


This package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.