[Bug 226045] Merge Review: libSM
bugzilla at redhat.com
bugzilla at redhat.com
Sat Mar 7 22:11:01 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226045
Jason Tibbitts <tibbs at math.uh.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |CLOSED
Resolution| |RAWHIDE
AssignedTo|nobody at fedoraproject.org |tibbs at math.uh.edu
Flag| |fedora-review+
--- Comment #3 from Jason Tibbitts <tibbs at math.uh.edu> 2009-03-07 17:10:59 EDT ---
I made the same basic changes I made to libICE:
- Minor tweaks to summaries and descriptions.
- Don't own /usr/include/X11.
- Use a regular, unversioned dep on xorg-x11-filesystem.
With this rpmlint says just:
libSM.x86_64: W: shared-lib-calls-exit /usr/lib64/libSM.so.6.0.0
exit at GLIBC_2.2.5
libSM-devel.x86_64: W: no-documentation
which are fine, although I don't get why the X libs all call exit. Seems like
that's the last thing you'd want deep in a client.
* source files match upstream. sha256sum:
7536ac382e1ff82014d3a0defba0c61b3a30984f4e5bc7707960d6debcb92a82
libSM-1.1.0.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
libSM-1.1.0-5.fc11.x86_64.rpm
libSM.so.6()(64bit)
libSM = 1.1.0-5.fc11
libSM(x86-64) = 1.1.0-5.fc11
=
/sbin/ldconfig
libICE.so.6()(64bit)
libSM.so.6()(64bit)
libuuid.so.1()(64bit)
libSM-devel-1.1.0-5.fc11.x86_64.rpm
pkgconfig(sm) = 1.1.0
libSM-devel = 1.1.0-5.fc11
libSM-devel(x86-64) = 1.1.0-5.fc11
=
/usr/bin/pkg-config
libICE-devel
libSM = 1.1.0-5.fc11
libSM.so.6()(64bit)
pkgconfig
pkgconfig(ice)
pkgconfig(xproto)
xorg-x11-filesystem
xorg-x11-proto-devel
* shared libraries are installed.
ldconfig called properly
unversioned .so link is in the -devel package.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files.
* scriptlets are OK (ldconfig).
* code, not content.
* headers are in the -devel package.
* pkgconfig files are in the -devel package.
* no static libraries.
* no libtool .la files.
APPROVED, and closing.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
More information about the package-review
mailing list