[Bug 480279] Package Review for gnome-globalmenu

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480279





--- Comment #11 from Alexey Torkhov <atorkhov at gmail.com>  2009-03-08 04:21:48 EDT ---
Do you need a sponsor? If so, FE-NEEDSPONSOR bug should be blocked.

- Package fails to build in mock. Need to add intltool, libwnck-devel,
libXres-devel to BuildRequires.

- Use %{?rhel} macro to check rhel version:
https://fedoraproject.org/wiki/Packaging/DistTag#Conditionals

- rpmlint is saying enormous number of errors and warnings that should be
fixed:
gnome-globalmenu.src: W: no-version-in-last-changelog
gnome-globalmenu-common.x86_64: E: postin-without-ldconfig
/usr/lib64/libgnomenu-0.7.4.so.2.0.0
gnome-globalmenu-common.x86_64: E: library-without-ldconfig-postun
/usr/lib64/libgnomenu-0.7.4.so.2.0.0
gnome-globalmenu-common.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/pkgconfig/libgnomenu.pc
gnome-globalmenu-common.x86_64: W: non-conffile-in-etc
/etc/gconf/schemas/gnome-globalmenu.schemas
gnome-globalmenu-common.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/libgnomenu.so
gnome-globalmenu-common.x86_64: E: description-line-too-long This package
contains shared data and libraries of various Global Menu packages.
gnome-globalmenu-common.x86_64: W: no-version-in-last-changelog
gnome-globalmenu-debuginfo.x86_64: W: no-version-in-last-changelog
gnome-globalmenu-devel.x86_64: W: no-documentation
gnome-globalmenu-devel.x86_64: W: no-version-in-last-changelog
gnome-globalmenu-gnome-panel.x86_64: W: no-documentation
gnome-globalmenu-gnome-panel.x86_64: E: explicit-lib-dependency libnotify
gnome-globalmenu-gnome-panel.x86_64: E: explicit-lib-dependency libwnck
gnome-globalmenu-gnome-panel.x86_64: W: no-version-in-last-changelog
gnome-globalmenu-gtkmodule.x86_64: W: no-documentation
gnome-globalmenu-gtkmodule.x86_64: W: no-version-in-last-changelog
gnome-globalmenu-xfce-panel.x86_64: W: no-documentation
gnome-globalmenu-xfce-panel.x86_64: E: explicit-lib-dependency libwnck
gnome-globalmenu-xfce-panel.x86_64: W: no-version-in-last-changelog
7 packages and 0 specfiles checked; 6 errors, 14 warnings.

In particular:
- All subpackages with shared libraries should have ldconfig calls:
https://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries

- Drop all explicit library dependencies in favour of rpm automatic dependency
finder.

- Description lines should be less 80 symbols.

- Add version to at least last changelog entry.


- Spec template gnome-globalmenu.spec.in will generate bad name for svn
snapshots like "0.7.4-1234-1.fc10". It should be like "0.7.4-0.1.1234svn.fc10"
instead:
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.