[Bug 488908] Review Request: cpptest - A portable and powerful and simple unit testing framework for C++

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488908


Michael Schwendt <bugs.michael at gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |bugs.michael at gmx.net
         AssignedTo|nobody at fedoraproject.org    |bugs.michael at gmx.net
               Flag|                            |fedora-review?




--- Comment #1 from Michael Schwendt <bugs.michael at gmx.net>  2009-03-08 13:35:05 EDT ---
$ rpmlint cpptest-1.1.0-1.fc10.src.rpm 
cpptest.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 19)


* The pkg-config template file contains a hardcoded "/lib" in libdir. This
won't work on 64-bit multi-arch platforms. Use  libdir=@libdir@  instead.


* The -devel package ought to "Requires: pkgconfig" since it places a file in
%_libdir/pkgconfig/ (and there is no automatic dependency on all platforms).


* Installation of documentation is messed up (upstream dist bug).
All files in /usr/share/doc/cpptest-devel-1.1.0/images/ are included in
../html/ already. In "images/" they are misplaced and incomplete.


* The %check section runs "make check", which is a no-op. The "test" target is
built already during %build. If you run "cd test && make check", the tests
fail:

FailTestSuite: 2/2, 50% correct in 0.000017 seconds
CompareTestSuite: 3/3, 33% correct in 0.000009 seconds
ThrowTestSuite: 2/2, 50% correct in 0.000226 seconds
Total: 7 tests, 42% correct in 0.000252 seconds

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.