[Bug 480851] Review Request: ccrypt - Secure encryption and decryption of files and streams

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480851





--- Comment #6 from Fabian Affolter <fabian at bernewireless.net>  2009-03-08 17:56:10 EDT ---
Thanks for your help.

(In reply to comment #4)
> - a test-suite is included in the sources in the "check" directory, you should
> add a %check section containing "make check" into the spec file

At the moment there is an issue with the 'check'

-------<%---------

BC=8, KC=8, Inverse difference a0[i][j]=232, a1[j*4+i]=-30
BC=8, KC=8, Inverse difference a0[i][j]=8, a1[j*4+i]=109
Inverse: 32 differences
Total: 647 differences
The optimized Rijndael implementation does not agree with the reference
implementation.
FAIL: rijndael-check
ccrypt: key does not match
./length-check.sh: test failed for file length 0.
FAIL: length-check.sh
./ccrypt-check.sh:57: Action returned 4 instead of 0.
./ccrypt-check.sh: test failed.
FAIL: ccrypt-check.sh
Random seed: 1236549206
Passed.
PASS: crypt3-check
===================
3 of 4 tests failed
===================
make[2]: *** [check-TESTS] Fehler 1
make[2]: Leaving directory `/home/fab/rpmbuild/BUILD/ccrypt-1.7/check'
make[1]: *** [check-am] Fehler 2
make[1]: Leaving directory `/home/fab/rpmbuild/BUILD/ccrypt-1.7/check'

-------%>---------  

(In reply to comment #5)
> (In reply to comment #4)
> > - the failure on ppc64 is a result of buggy code in maketables or a bug in GCC
> > in combination with our security related compiler flags and you can ask for
> > access to ppc654 system on fedora-devel for further investigation  
> 
> so it's buggy code ->
> the "r" array on line 133 (maketables.c) consists of too small members (word8)
> for storing word32 values as returned by function multrot2113  

Added a patch for this.  Now it works on ppc64.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.