[Bug 472150] Review Request: coot - crystallographic macromolecular building toolkit

bugzilla at redhat.com bugzilla at redhat.com
Mon Mar 9 08:18:27 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472150





--- Comment #13 from Tim Fenn <fenn at stanford.edu>  2009-03-09 04:18:26 EDT ---
(In reply to comment #12)
> This failed to build for me in rawhide; it looks like it will need some fixes
> in order to build with gcc 4.4:
> 

OK - once I get my devel machine working with gcc 4.4 I'll fix this (waiting
for the beta freeze)

> 
> About the rpmlint complaints, the unused-direct-shlib-dependency ones just
> indicate that a library is linked against libm but doesn't actually call any
> functions in it.  It's not really a problem.
> 
> All of the undefined-non-weak symbol complaints come from the fact that one
> library calls functions in another without being linked against it.  Things
> still work because the the final executables link against all of the libraries.
>  It's really bad form, but unless the libraries are expected to be used by
> other packages it's not really a huge problem.  It's something I would complain
> to upstream about and perhaps try to work out a fix (after all, it is a lot of
> rpmlint warnings and it shouldn't be all that hard to make them go away) but I
> don't think it would block this review.
> 

Thanks for the tips.  I've sent all my patches upstream, hopefully the next
point release will fix most of these problems.

> Also, you probably don't want to pass --vendor=fedora to desktop-file-install.  

Oops, thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list