[Bug 489323] Package Review: Separate ecj RPM

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=489323


Lillian Angel <langel at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Lillian Angel <langel at redhat.com>  2009-03-09 11:22:02 EDT ---
Everything is fine. Only one question about file permissions, but otherwise the
package is approved.

* 1 Packaging Guidelines
  o 1.1 Naming
 ok
  o 1.2 Version and Release
 ok
  o 1.3 Legal
 ok
  o 1.4 No inclusion of pre-built binaries or libraries
 ok
  o 1.5 Spec Legibility
 ok
  o 1.6 Writing a package from scratch
 ok
  o 1.7 Modifying an existing package
 ok
  o 1.8 Architecture Support
 ok
  o 1.9 Filesystem Layout
 ok
  o 1.10 Use rpmlint
 none!
  o 1.11 Changelogs
 ok
  o 1.12 Tags
 ok
  o 1.13 BuildRoot tag
 ok
  o 1.14 %clean
 ok
  o 1.15 Requires
        ok
  o 1.16 BuildRequires
 ok
  o 1.17 Summary and description
 ok
  o 1.18 Encoding
 ok
  o 1.19 Documentation
 about.html - ok
  o 1.20 Compiler flags
 ok
  o 1.21 Debuginfo packages
 ok
  o 1.22 Devel Packages
 n/a
  o 1.23 Requiring Base Package
 ok
  o 1.24 Shared Libraries
 n/a
  o 1.25 Packaging Static Libraries
 n/a
  o 1.26 Duplication of system libraries
 n/a
  o 1.27 Beware of Rpath
 n/a
  o 1.28 Configuration files
 n/a
  o 1.29 Initscripts
 n/a
  o 1.30 Desktop files
 n/a
  o 1.31 Macros
 ok
  o 1.32 Handling Locale Files
 ok
  o 1.33 Timestamps
 ok
  o 1.34 Parallel make
 n/a
  o 1.35 Scriptlets
 n/a
  o 1.36 Conditional dependencies
 n/a
  o 1.37 Build packages with separate user accounts
 n/a
  o 1.38 Relocatable packages
 n/a
  o 1.39 Code Vs Content
 n/a
  XXXX 1.40 File and Directory Ownership
 Is there a reason %defattr(-,root,root) was used instead of
%defattr(-,root,root,-)?
  o 1.41 Users and Groups
 n/a
  o 1.42 Web Applications
 n/a
  o 1.43 Conflicts
 ok
  o 1.44 No External Kernel Modules
 n/a
  o 1.45 No Files or Directories under /srv
 n/a
  o 1.46 Bundling of multiple projects
 n/a
  o 1.47 All patches should have an upstream bug link or comment
 n/a
  o 1.48 Application Specific Guidelines
        + Java
  all ok
 + GCJ
  all ok

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.