[Bug 489130] Review Request: gnome-guitar - A small suite of applications for the guitarist

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=489130


Christian Krause <chkr at plauener.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chkr at plauener.de




--- Comment #4 from Christian Krause <chkr at plauener.de>  2009-03-09 19:47:43 EDT ---
Hi Orcan,

I've reviewed your request. Please consider this as an inofficial review since
I'm new in the packager's group. I hope I could help anyway. ;-)

* rpmlint: OK
rpmlint RPMS/i386/gnome-guitar-* SRPMS/gnome-guitar-0.8.1-1.fc10.src.rpm 
gnome-guitar.i386: E: no-binary
gnome-guitar.i386: E: only-non-binary-in-usr-lib
gnome-guitar.i386: W: conffile-without-noreplace-flag
/etc/gconf/schemas/libgnomeguitar.schemas
gnome-guitar-devel.i386: W: no-documentation
3 packages and 0 specfiles checked; 2 errors, 2 warnings.

as already explained in the request, these are false positives

* name: OK
- upstream has slightly different name: gnome-guitar_cs, but according to the
NamingGuidelines it is possible to change it e.g. if the original name uses
wrong characters or would be somehow strange ;-)
- ubuntu also already named the package without _cs

* spec file name matches %{name}: OK

* License: OK
- License tag matches actual license
- project ships gpl-3.0.txt in the various subdirectories
- no restrictions to explicitly 3.0, so GPLv3+ is ok

* License file packaged: OK

* spec file in English: OK

* spec file legible: OK

* source tarball match upstream: OK
- spectool -g SPECS/gnome-guitar.spec works
- sha1sum: b6ea73215c53a0b8bd11cc01f1a8969389170d57 
gnome-guitar_cs-0.8.1.tar.gz
- md5sum: 9bb146c8667fe503739ae7ff8b4d4213  gnome-guitar_cs-0.8.1.tar.gz

* package compilable: BAD
- compiles in F10, i386
- fails at least for the 64 bit archs
- https://koji.fedoraproject.org/koji/taskinfo?taskID=1233610
- https://koji.fedoraproject.org/koji/taskinfo?taskID=1233605
- https://koji.fedoraproject.org/koji/taskinfo?taskID=1233600
- problem should be either fixed or the architectures should be excluded in the
spec file

* BuildRequirements: OK

* pre/post requires: OK
- GConf2 required
- no need to require a package for gtk-update-icon-cache (according to
packaging
guidlines)

* locales handling: OK (no locales)

* shared libs handling: OK (no shared libs)

* owns all created directories: OK

* no duplicates in %files: OK

* file permissions: OK
- %defattr used

* %clean section: OK

* macros usage: OK

* package contains only code, no content: OK

* documentation: OK (no documentation available)

* header in -devel: OK (no headers)

* static lib in -static: OK (no static lib)

* devel packages containing pkgconfig files must require pkgconfig: BAD

* handling of *.so files: OK (no shared libs)

* devel package requires base package: OK

* no *.la files: OK

* gui application requires *.desktop file: OK
- gnome-chord.desktop
- gnome-scale.desktop
- integrate correctly into menu (tested in gnome)

* package ownes files/dirs already owned: OK

* rm -rf %{buildroot} at beginning of %install: OK

* filenames UTF-8: OK

* package works: OK
- both programs gnome-chord and gnome-scale basically work on F10, can be
started from menu, no segfault etc. within a short test period

* GTK+ icon cache: seems to be ok, however it differs sligthly from the example
in http://fedoraproject.org/wiki/Packaging/ScriptletSnippets

Regards,
Christian

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.