[Bug 478432] Review Request: dwscan - Displays access point information

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478432


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review?

Bug 478432 depends on bug 478300, which changed state.

Bug 478300 Summary: Review Request: python-wifi - Python binding for the wireless extensions
https://bugzilla.redhat.com/show_bug.cgi?id=478300

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
             Status|ASSIGNED                    |ON_QA
         Resolution|                            |NEXTRELEASE
             Status|ON_QA                       |CLOSED



--- Comment #3 from Jason Tibbitts <tibbs at math.uh.edu>  2009-03-09 21:51:12 EDT ---
I'm guessing that Ralf's concern was that the program needs privilege to run
and so should be installed in /usr/sbin.  Of course, the current default path
kind of eliminates the difference, but upstream seems to agree.  Do you have
any thoughts on this?

The software seems confused about its license.  The actual program clearly
indicates LGPLv2 (only) but COPYING and the included spec say GPLv2.  The
software itself overrides, of course, but then I don't see the value in
packaging the useless COPYING file.  Could you ping upstream and see if you can
get them to clarify?

Are you sure this really needs python to build?  It doesn't seem to me like it
does.

* source files match upstream.  sha256sum:
   84d2161d1b9714d4517cef811a35fe53fdddfd5b22a2693811ccae02ed1ef779  
   dwscan-0.2.tar.bz2
* package meets naming and versioning guidelines.
 specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
X license field does not match the actual license.
* license is open source-compatible.
* latest version is being packaged.
X BuildRequires
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   dwscan = 0.2-2.fc11
  =
   /usr/bin/python
   python-wifi

* owns the directory it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.


The package review process needs reviewers!  If you haven't done any package
reviews recently, please consider doing one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.