[Bug 488963] Review Request: transifex - A system for distributed translation submissions

bugzilla at redhat.com bugzilla at redhat.com
Tue Mar 10 08:00:38 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488963


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review?




--- Comment #4 from Parag AN(पराग) <panemade at gmail.com>  2009-03-10 04:00:36 EDT ---
+ is ok
- needs work
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1234065
+ rpmlint is silent for SRPM 
- rpmlint is NOT silent for noarch RPM.
transifex.noarch: E: explicit-lib-dependency python-polib
You must let rpm find the library dependencies by itself. Do not put unneeded
explicit Requires: tags.
==> can be ignored.
transifex.noarch: W: spurious-bracket-in-%post
The %post scriptlet contains an "if []" construct without a space before the
"]".
==>fix this before cvs import

+ source files cannot be verified as this is mercurial checkout snapshot.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.

Suggestions:
1) from build.log I see syntax error 
+ /usr/lib/rpm/brp-python-bytecompile
Compiling
/builddir/build/BUILDROOT/transifex-0.5-0.2.fc11.hg9f575f26d1db.noarch/usr/share/transifex/repowatch/update.py
...
SyntaxError: ('invalid syntax', ('/usr/share/transifex/repowatch/update.py',
60, 44, '                key=operator.itemgetter(0)):\n'))

This is not happening on F10 python-2.5. Can this be fixed either before cvs
import or after importing package?

2)Not sure whether WARNING in build.log really need to be fixed. If you see it
needs then please fix that also.

3)unable to install package as django-evolution is not built for F10/F11


Also,
     What is for %post is used? Good if you comment in SPEC for what purpose
you want %post lines?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list