[Bug 483451] Review Request: k3guitune - Musical instrument tuner

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483451





--- Comment #6 from David Timms <dtimms at iinet.net.au>  2009-03-10 08:22:27 EDT ---
(In reply to comment #5)
> Actually, I spent some more time on this and finished the review. There are
> only a few more issues remaining:
OK, great thanks for that, I think I got all changes, although I prefer that
the URL and source paths use the actual name rather than the macro, to simplify
being able to check that the paths really exist. If the name was changed, it
would be unlikely to be on the same server etc, so I don't think that using the
macro is appropriate.

Since the jack wrapper/lib is not yet in fedora, I haven't included that, but
will look again once it does get in.

Update spec,srpm:
http://members.iinet.net.au/~timmsy/k3guitune/k3guitune.spec
http://members.iinet.net.au/~timmsy/k3guitune/k3guitune-1.01-3.fc10.src.rpm

Changes:
- mod icon cache update to use newly ratified scriptlets
- enable jack audio support via BR: bio2jack
- mod symlink fix to be more flexible in the future
- remove install of INSTALL
- mod to use more macro style invocations, except url and source
- del Requires: hicolor-icon-them since it wil be detected via kdelibs3
- clarify License tag since some source files are licensed GPLv2 only.
- fix previous changelog date

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.