[Bug 488124] Review Request: gnubik - 3D interactive graphics puzzle

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488124


Orcan 'oget' Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oget.fedora at gmail.com




--- Comment #1 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-03-11 11:35:10 EDT ---
My initial notes:

* The package fails to build (also the above koji links didn't give me
anything). 
   File not found by glob:
/builddir/build/BUILDROOT/gnubik-2.3-1.fc10.x86_64/usr/share/pixmap/gnubik.*
   File not found by glob:
/builddir/build/BUILDROOT/gnubik-2.3-1.fc10.x86_64/usr/share/man/man*/gnubik*

This line looks problematic:
   install -Dp -m 644 doc/%{name}.6 $RPM_BUILD_ROOT%{_mandir}/man6/%{name}.6

Try to create the directory before installing the file.

* As far as I know, %{_datadir}/pixmaps is being deprecated and the new
applications should install their pixmaps under
%{_datadir}/icons/hicolor/<dim>x<dim>/apps/
where <dim> is 32 in your case.

! Please add a "Comment" key to the .desktop file. This could be useful for
gnome users.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.