[Bug 488124] Review Request: gnubik - 3D interactive graphics puzzle

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488124





--- Comment #2 from Alexey Torkhov <atorkhov at gmail.com>  2009-03-11 12:34:27 EDT ---
(In reply to comment #1)
> * The package fails to build (also the above koji links didn't give me
> anything). 
>    File not found by glob:
> /builddir/build/BUILDROOT/gnubik-2.3-1.fc10.x86_64/usr/share/pixmap/gnubik.*
>    File not found by glob:
> /builddir/build/BUILDROOT/gnubik-2.3-1.fc10.x86_64/usr/share/man/man*/gnubik*
> 
> This line looks problematic:
>    install -Dp -m 644 doc/%{name}.6 $RPM_BUILD_ROOT%{_mandir}/man6/%{name}.6
> 
> Try to create the directory before installing the file.

Thanks. Install key -D somehow fails when building in mock.

> * As far as I know, %{_datadir}/pixmaps is being deprecated and the new
> applications should install their pixmaps under
> %{_datadir}/icons/hicolor/<dim>x<dim>/apps/
> where <dim> is 32 in your case.

Pixmaps dir is listed is seem not listed as deprecated in standard:
http://standards.freedesktop.org/icon-theme-spec/latest/ar01s03.html

> ! Please add a "Comment" key to the .desktop file. This could be useful for
> gnome users.  

Fixed.


Spec URL: http://atorkhov.fedorapeople.org/gnubik.spec
SRPM URL: http://atorkhov.fedorapeople.org/gnubik-2.3-2.fc10.src.rpm

* Wed Mar 11 2009 Alexey Torkhov <atorkhov at gmail.com> - 2.3-2
- Don't using install -D that doesn't want to work in mock
- Fix incorrect usage of GenericName in desktop file

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.