[Bug 488124] Review Request: gnubik - 3D interactive graphics puzzle

bugzilla at redhat.com bugzilla at redhat.com
Wed Mar 11 16:48:17 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488124





--- Comment #3 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-03-11 12:48:17 EDT ---
(In reply to comment #2)
> (In reply to comment #1)
> 
> > * As far as I know, %{_datadir}/pixmaps is being deprecated and the new
> > applications should install their pixmaps under
> > %{_datadir}/icons/hicolor/<dim>x<dim>/apps/
> > where <dim> is 32 in your case.
> 
> Pixmaps dir is listed is seem not listed as deprecated in standard:
> http://standards.freedesktop.org/icon-theme-spec/latest/ar01s03.html
> 

No, it's not deprecated, but to my knowledge, it is _being_ deprecated. At
least, comparing the size of pixmaps and hicolor directories, I think the
preference in Fedora is the latter. Also, I saw packages in Fedora, where the
images (that were installed by "make install") were moved from pixmaps to
hicolor in the %install section. I may be wrong with this so this is by no
means a blocker, you can keep images in pixmaps.

But if you use hicolor, please use the correct scriptlets from
   http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
Also, I think the image size is 32, not 48.

In addition, the %files section needs to be modified accordingly.

> > ! Please add a "Comment" key to the .desktop file. This could be useful for
> > gnome users.  
> 
> Fixed.
> 
> 

Thanks. But you didn't need to remove the GenericName. KDE makes use of
GenericName, while gnome uses Comment. I think it is best to have both of them.

I will go over this package and do the full review asap.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list