[Bug 489803] Review Request: libserial - C++ library to access serial ports on POSIX systems

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=489803





--- Comment #4 from Alex71 <nyrk71 at gmail.com>  2009-03-12 06:05:14 EDT ---
Thanks Ralf for your informal review.

While waiting for the formal review from Kevin, I add other hints coming from
an other informal review (thanks to musuruan)

1 - remove from %install the line:
echo RPM_BUILD_ROOT $RPM_BUILD_ROOT 
(it had just a debug purpose)

2 - there are some residual "libserial" string instead of  %{name} 

3 - when copying the man pages, user "cp -a" to preserve attributes (such as
timestamp)

4 - write a better changelog

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.